Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Group Requirements Notification Job Not Respecting Applies to Age Classification Setting #5564

Closed
1 task done
mikedotmundy opened this issue Aug 30, 2023 · 1 comment

Comments

@mikedotmundy
Copy link

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

The Send Group Requirements Notification Job is not correctly handling the Applies to Age Classification setting on a Group Requirement.

If you set the Applies to Age Classification on a Group Requirement to "Adults" (so the requirement only applies to adults), the job ignores this setting and will still include children in the sent notification, assuming they do not meet the requirement.

Looking at the GroupMemberRequirement table, I believe this has to do with the job looking to see if there is no value in the RequirementMetDateTime column AND/OR there is a value in the RequirementFailDateTime column.

Expected Behavior

As in my example above, if you set the Applies to Age Classification to "Adults", then the Send Group Requirements Notification Job should exclude Children.

Actual Behavior

After setting the Applies to Age Classification to "Adults", the Send Group Requirements Notification Job still includes children in the notification.

Steps to Reproduce

  • Go to the "Children's" Group (/Group/59). Add Cindy and Noah Decker as Members. Make sure Cindy is a Leader.
  • Give Cindy a valid Background Check in her Extended Attributes.
  • On the Serving Team Group Type, enable "Specific Group Member Requirements".
  • Back on the Group, create a Group Member Requirement for Background Checks. Make sure to apply it to Adults only.
  • Run the Calculate Group Requirements Job
  • Setup and run the Send Group Requirements Notification Job.
  • See that Noah Decker is included in the Notification. He should not be, because he is a child and the requirement does not apply to him.

Rock Version

v15.1, v16.0

Client Culture Setting

en-US

@mikedotmundy mikedotmundy changed the title Send Group Requirements Notification Not Respecting Applies to Age Classification Setting Send Group Requirements Notification Job Not Respecting Applies to Age Classification Setting Aug 30, 2023
ethan-sparkdevnetwork added a commit that referenced this issue Oct 9, 2023
…oup Requirement Notifications jobs where the Age Classification of the Requirement were not being considered. (Fixes #5564)
@RufenachtPW
Copy link

I think this will also fix the group scheduler when a group is set to must meet requirements in order to schedule. The group scheduler has the same issue that applied the requirement to all group members and did not respect the age classification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants