Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Group Requirements Notification Job Includes People No Longer in Warning State #5565

Closed
1 task
mikedotmundy opened this issue Aug 30, 2023 · 0 comments
Closed
1 task

Comments

@mikedotmundy
Copy link

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

The Send Group Requirements Notification Job is including people in the notification who previously were in a warning state, but have since met the requirement.

Consider the following example:

  • Because Cindy Decker's Background check was going to expire soon, she met the criteria to enter a warning state on 5/5/2023.
  • Because the Rock Solid Church Staff is excellent at what they do, they had Cindy complete a new Background Check in record-breaking time, on 5/7/2023.
  • That next morning, the Calculate Group Requirements Job ran. In the GroupMemberRequirement table, Cindy's RequirementMetDateTime column was updated to 5/8/2023. However, the RequirementWarningDateTime column was not changed, and remained at 5/5/2023 (the date she entered a warning state).

The issue is the next time the Send Group Requirements Notification Job runs. The notification email shows "Background Check Expiring Soon as of 5/5/2023. Cindy should not be included in the notification at all, because she now meets the requirement.

This is a screenshot from our environment of the notification, using the scenario above:
Screenshot 2023-08-30 at 07 39 36

This is a screenshot from our environment of the person above's GroupMemberRequirement table:
Screenshot 2023-08-30 at 07 45 46

Expected Behavior

In my example above, Cindy should not be included in the notification sent out by the Send Group Requirements Notification Job.

Actual Behavior

In my example above, Cindy should is included in the notification sent out by the Send Group Requirements Notification Job.

Steps to Reproduce

See above

Rock Version

v15.1, v16.0

Client Culture Setting

en-US

ethan-sparkdevnetwork added a commit that referenced this issue Oct 9, 2023
…e persons previously in a warning state still showed as warning after the requiremnt has been met. (Fixes #5565)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants