Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive Phone Numbers still shown and work on Communication pages #5597

Closed
1 task done
bobrufenacht opened this issue Sep 12, 2023 · 1 comment
Closed
1 task done
Labels
Fixed in v16.1 Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@bobrufenacht
Copy link
Contributor

bobrufenacht commented Sep 12, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Inactive System Phone Numbers are still available for use in communications. (Seems like a similar issue was reported but I could not find it.)

Expected Behavior

Inactive System Phone Numbers would not show in the selections on the Simple and Wizard Communication editors once they are marked inactive.

Actual Behavior

All numbers appear in the list of selectable values and continue to work for communications bidirectionally even if marked inactive.

Steps to Reproduce

  • System Phone Number page and inactivate a phone number (or add an inactive number)
  • Navigate to either the Communication Wizard or the Simple Communication page.
  • Select SMS option
  • Open the dripdown of phone numbers and the inactive number will be shown in the list.

Rock Version

14.3, 15.1

Client Culture Setting

en-US

@darringraham
Copy link

I can verify this behavior in v15.1. Both the New Communication and Simple Communication pages show SMS numbers regardless of whether they are Active or Inactive in System Phone Numbers.

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Priority: Low Affects a small number of Rock installations and will not be noticed by most users. labels Sep 14, 2023
ethan-sparkdevnetwork added a commit that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

4 participants