Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Workflow Form Fields Do Not Display Correctly after Partial Postback #5602

Closed
2 tasks done
azturner opened this issue Sep 14, 2023 · 4 comments
Closed
2 tasks done
Labels
Fixed in v16.3 Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@azturner
Copy link
Contributor

Description

When using conditional form fields in a workflow, they are displayed correctly when form first loads and when user interacts with fields, but if the block does a partial-post back (i.e. when selecting the country in an address field when international addresses are enabled), the conditional fields disappear.

Actual Behavior

After partial-post back conditional fields are not displayed even though their condition is valid

Expected Behavior

Conditional fields should continue to be displayed correctly based on their configured conditions even after a partial-postback.

Steps to Reproduce

  • Go to Global Attributes and enable International Addresses
  • Create a workflow that has three fields. The first two fields can be text fields, but the third should be an address field.
  • Add a Form action to the workflow that shows all three fields as editable and configure the second field to be conditional based on value of the first field.
  • Run the workflow and change first field to the value that second field is conditional on. The second field will then show.
  • Change the country of the address field.

The second field will then disappear even though the criteria is met for showing it.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v13.8, v15.1

Client Culture Setting

en-US

@nairdo
Copy link
Member

nairdo commented Oct 4, 2023

Hi @azturner David, Several of us have tried to reproduce this issue, in a few different versions of Rock, but we've been unsuccessful. Can you tell us if there is another step that we're missing which is not shown above. Here is one of our attempts on v15.1. I also attached the Workflow Type export so you can try what we're trying:
Test #5602_202310041535.zip

Issue5602_chrome_q9AmrAgmBZ.mp4

@azturner
Copy link
Contributor Author

azturner commented Oct 5, 2023

Strange, I can't reproduce it now either. I'll close the issue, Thank you for looking into it.

@azturner azturner closed this as completed Oct 5, 2023
@tcavaletto
Copy link
Contributor

@nairdo We're encountering this issue as well, specifically on a v15.2 sandbox and the v15.1 demo server. To test on the demo server, I created a workflow with:

  • A Boolean field defaulting to 'True'
  • An Attribute Matrix field that only shows when the boolean field is set to true.

I think it has something to do with the conditional having issues when it checks an attribute's default value. On first load, when I try to add a matrix item, the control disappears. However, if I select 'False' and then select 'True' again, the matrix remains.

Partial Postback Test_202310191155.json

@nairdo
Copy link
Member

nairdo commented Oct 19, 2023

We'll try using that exported example workflow.

@nairdo nairdo reopened this Oct 19, 2023
@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. and removed Not Yet Reproduced labels Dec 4, 2023
@PraveenMathew92 PraveenMathew92 added Fixed in v16.3 and removed Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Dec 27, 2023
PraveenMathew92 added a commit that referenced this issue Jan 4, 2024
…ional Workflow Form Fields. (Fixes #5602)"

This reverts commit ec634a5.
@nairdo nairdo reopened this Jan 9, 2024
@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Jan 19, 2024
PraveenMathew92 added a commit that referenced this issue Jan 23, 2024
@PraveenMathew92 PraveenMathew92 added Fixed in v16.3 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.3 Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants