Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fundraising Matching Block does not allow clearing previously matched transaction #5636

Closed
2 tasks done
azturner opened this issue Oct 18, 2023 · 6 comments
Closed
2 tasks done
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@azturner
Copy link
Contributor

Description

In the fundraising matching block, if you assign a transaction to a specific group/member, you cannot then clear that selection. The UI allows clearing the value, but after clicking Save, the group member re-appears in the selection for that transaction.

Actual Behavior

Clearing the group member selection does not save.

Expected Behavior

If you clear the value in the UI, it should save the cleared value.

Steps to Reproduce

  • Setup at lease one fundraising opportunity group with at least one member.
  • Add a financial batch and transaction.
  • Go to the fundraising matching page
  • Select the batch that was just created
  • Match the single transaction in the batch to the member of the fundraising opportunity group
  • Save changes.
  • Clear the group member selection
  • Save changes
  • Group member re-appears after the change.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v12.8, v15.1

Client Culture Setting

en-US

@jonedmiston
Copy link
Member

Similar to this issue: #5406

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Oct 19, 2023
@sparkdevnetwork-service sparkdevnetwork-service added the Type: Bug Confirmed bugs or reports that are very likely to be bugs. label Nov 1, 2023
Kwame-Agyei added a commit that referenced this issue Nov 6, 2023
…allow clearing previously matched transactions. (Fixes #5636)
@Kwame-Agyei Kwame-Agyei added Fixed in v16.1 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Nov 6, 2023
@tbunney
Copy link

tbunney commented Dec 6, 2023

I just tested this in Alpha version 1.16.1.1 and I can still not clear a previously matched transactions.

I cleared them, then clicked Save. Refreshed the page, and they were showing again.

@chead4
Copy link

chead4 commented Dec 6, 2023

@tbunney Hi Tiffany I am unable to recreate this issue on v16.1. If you could supply a video that would be very helpful as I may be doing something different than you are.

@tbunney
Copy link

tbunney commented Dec 7, 2023 via email

@chead4
Copy link

chead4 commented Dec 7, 2023

@tbunney Thank you for the video. I was removing the Group Member and not the Group in my test. I was able to recreate.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Dec 8, 2023
@chead4 chead4 reopened this Dec 8, 2023
@nairdo
Copy link
Member

nairdo commented Dec 12, 2023

@tbunney Just a quick update. We've put a new fix (39797d2) into the v16.1 alpha package for the round no. 2 testing which is about to begin. Please let us know if that does not resolve the issue for you or if you run into any troubles with this.

@nairdo nairdo closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

7 participants