CheckinGroupList falsely throws an Infinite Recursion on highly nested group types

[tcavaletto]

Description

When dealing with a nested checkin configuration like below, CheckinGroupList falsely throws an infinite recursion.

I believe the issue lies here: https://github.com/SparkDevNetwork/Rock/blob/1.15.1/RockWeb/Blocks/CheckIn/CheckinGroupList.ascx.cs#L176. As you can see below, when grabbing the parent group type, it sets the groupType variable, adds the now new group type id to the parentRecursionHistory list, and then compares it against a list that will always already have it. I suggest setting a groupTypeId variable at the beginning of the while loop, and adding that to the recursion list at the end of the while loop. That way we're adding the original groupTypeId instead of the parent groupTypeId prematurely.

Actual Behavior

We see the following:

Expected Behavior

We should see

Steps to Reproduce

• Go to Attendance Analytics
• Select the Weekly Service Check-in
• Click the Checkin Detail button:
  
• Select a group and attendance occurrence, for example the test group. See the expected behavior:
  
• In a new tab, simulate a more nested setup by adding a new group type underneath the weekly checkin config. Remove your relevant group type ( In this case, Checkin Test Area) from the weekly checkin config group type's Child Group Types, and add it to your new group type, so that it looks like this:
  
• Refresh your attendance detail tab:
  
• See Error

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.2, 14.2

Client Culture Setting

en-US