Issues w/Single-Line Lava Comments

[briankalwat]

Description

We recently deployed version 17.0.5 and it appears there are some issues with the single-line lava comment syntax.

Two things I've found thusfar:

1. Single-line lava comments in an HTML block cause the contents of the block to not be rendered:
   Example Lava:

//- Single line lava comment
<h2>This is a test.</h2>

2. When using single-line lava comments within the item tags of a block lava shortcode, an error is visible shown on the page, and an exception is logged for an error in the for loop.
   Example Lava:

{% assign array = 'One,Two,Three,Four,Five '%}
{% assign arrayObj = array | Split:',' %}
{[ accordion ]}
    {% for item in arrayObj %}
        [[ item title:'Item {{ item }}' ]]
            <p>This is an item.</p>
            //- this is a single line comment in a block shortcode item
        [[ enditem ]]
    {% endfor %}
{[ endaccordion ]}

I've reproduced both of these issues on rockrmslatest.com which is currently on 17.0.5, as well.

Actual Behavior

Single-line comments currently prevent HTML blocks from showing their contents, and block lava shortcodes from doing the same.

Expected Behavior

Single-line lava comments //- This is a comment should work as expected, hiding the comment but still displaying the rest of what's around them.

Steps to Reproduce

Put either of the two lava examples documented above in an html block on any Rock instance running 1.17.0.5.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

1.17.0.5

Client Culture Setting

en-US