Check-In Manager Live Metrics Broken if Groups Put Into Group Tree View

[bobrufenacht]

Description

On behalf of North Point Ministries

Check-In Manager Live Metrics page shows "The selected check-in type does not have any valid groups or locations." instead of working properly.

In 12.4 a fix was made to Check-In Manager to allow check-in groups to be put into a group viewer tree so that the groups can be edited (add/remove members for Already Belongs groups). Original Commit a5bda14.

In v15.2, someone removed this fix and broke it again with commit 806a16b.

The comment on undoing the fix is quite disturbing.

/*
SK - 07/02/2023
Reverted back changes made via a5bda14
- Fixed issue in Live Metrics where a 'no valid groups or locations' message would show if a Group had a non-checkin parent group.

    IF the other situation occurs again, we will have more details about where/why/how to handle it next.

*/

It basically says, "Let's break it again and see who complains." This is needed by many larger churches that have to use Already Belongs group that are manually maintained. The original commit outlined why it was needed.

Actual Behavior

Check-In Manager Live Metrics page shows "The selected check-in type does not have any valid groups or locations." instead of working properly.

Expected Behavior

Live Metrics should be shown.

Steps to Reproduce

• Put Already Belongs Groups into the Group Tree View structure.
• Go to Live Metrics in Check-In Manager.
• Error is displayed ("The selected check-in type does not have any valid groups or locations.")
• See error

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.2

Client Culture Setting

en-US

[bobrufenacht]

As a temprorary fix, you can comment out lines 756, 757 and 760 in LiveMetrics.ascx.cs to remove the If statement that prevents groups from being added to the group type (such that the groups types remain empty and are later removed). The above comment is directly above these lines of code.