Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian Group Scheduler block incorrectly places vertical lines indicating min / desired / max on status bar #5662

Closed
2 tasks done
leahjennings opened this issue Nov 2, 2023 · 0 comments
Labels
Fixed in v16.1 Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@leahjennings
Copy link
Collaborator

Description

The vertical lines of the status bar on the new Obisidian Group Scheduler are off by one. With one person pending out of three maximum, the bar correclty fills to 33% with the pending color, however, the vertical line indicating the desired amount of two people is also sitting at 33%.

image

Actual Behavior

image

It appears the width of the status bar is "split" into the number of slots designated as maximum. In the screenshot above, that would be 3. There is one pending assignment, so the pending color correclty fills to 33% of the maximum. However, the desired number is two, so the desired tooltip should be at 66% of the bar, but it sits at 33%.

Expected Behavior

I would expect the vertical lines indicating the minimum / desired / maximum would be correctly placed on the status bar in relation to how many "slots" the bar has been split into, so visually I can tell whether or not I'm at my minimum / desired.

Steps to Reproduce

  • On the demo site, navigate to People > Group Viewer
  • Click on the Ushers group, then click Edit
  • Expand Meeting Details, then click the pencil icon to edit the existing Meeting Details
  • Edit the Minimum / Desired / Maximum for each location to 1 / 2 / 3, respectively
image - Click Ok, then click Save to save changes made to the group - Navigate to People > Group Scheduling, then click on Group Scheduler - Open the Page Zones menu from the admin bar - Edit the Main Zone and add the new Obsidian Group Scheduler block (denoted in the list by the 🎉 icon) - Delete the old Webforms block image
  • Click on the Filters area of the new block and choose the Ushers group from the dropdown, then hit Apply
image
  • Click the + button next to one of the locations and click the checkbox to assign Ted Decker for that position
image
  • Notice how the desired line is correctly showing 2 with the tooltip, but with only one person scheduled, the bar fills up and seemingly visually indicates you've got two scheduled, even though there's only one scheduled
image

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.1 (1.15.1.1), 16.0 (1.16.0.12)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added the Type: Bug Confirmed bugs or reports that are very likely to be bugs. label Nov 3, 2023
jasonhendee added a commit that referenced this issue Nov 7, 2023
…red/maximum capacity progress bar markers to the right of the spot that satisfies a given value. (Fixes #5662)
jasonhendee added a commit that referenced this issue Nov 7, 2023
…red/maximum capacity progress bar markers to the right of the spot that satisfies a given value. (Fixes #5662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants