Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Bar Scroll event - Desktop Safari #5668

Closed
2 tasks done
atamburino opened this issue Nov 8, 2023 · 1 comment
Closed
2 tasks done

Nav Bar Scroll event - Desktop Safari #5668

atamburino opened this issue Nov 8, 2023 · 1 comment

Comments

@atamburino
Copy link

Description

On a standard side of rock the nav bar works as intended
image

Once the Nav bar enters the scroll state the "open" no longer functions
image

Actual Behavior

Working as intended -
Screenshot 2023-11-08 at 11 26 47 AM

Bug created by making screen shorter to activate scroll on navbar -
image

Expected Behavior

Open should work when the nav bar is on the scroll event.

Steps to Reproduce

  • Go to 'https://rock.rocksolidchurchdemo.com' using SAFARI
  • Login as admin admin
  • Test Nav bar on standard screen size (this should work)
  • Shorten page to force the nav bar to scroll OR add a ton of icons to the nav bar to force it into a scroll event.
  • See error

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.1 & 15.2

Client Culture Setting

en-US

@atamburino atamburino changed the title Main Menu Nav Bar - Desktop Safari Nav Bar Scroll event - Desktop Safari Nov 8, 2023
@andypullen
Copy link

andypullen commented Nov 8, 2023

We've seen this issue as well, on both Safari and Chrome-based browsers on macOS. Thanks for filling out the bug report!

Edit: I just tried it again in Chrome and Firefox on the Mac and it behaves as it should, so maybe I'm wrong and it was only our Safari users who came across it.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Nov 8, 2023
garrettjohnson added a commit that referenced this issue Nov 8, 2023
…display if the sidebar was scrolled in Safari. (Fixes #5668)
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants