Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailgun Webhooks Not Working If Webhook Signing Key Differs From API Key #5694

Closed
2 tasks done
mkinyon opened this issue Dec 13, 2023 · 1 comment
Closed
2 tasks done
Labels
Fixed in v14.4 Fixed in v15.4 Fixed in v16.1 Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Enhancement Feature requests.

Comments

@mkinyon
Copy link
Contributor

mkinyon commented Dec 13, 2023

Description

Submitted on behalf of Whitewater Crossing Church.

Email tracking with the Mailgun HTTP transport will not work if the HTTP webhook signing key and the API key are not the same. (The API key is used for sending email and the HTTP webhook signing key is used for email tracking.) These keys can get out of sync if a new API key is created or if the webhook signing key gets refreshed. Also, it doesn't seem possible to get these keys back in sync after one has been changed.

image

Actual Behavior

If the API key and HTTP webhook signing key differ in Mailgun, then either email sending or email tracking is not working depending on which key is entered into the Mailgun HTTP transport.

Expected Behavior

I would expect the Mailgun HTTP transport to have two settings for the API key instead of one. One for the API key and the other for the webhook signing key.

Steps to Reproduce

  • You will need a Mailgun account configured with an API key that is different than the HTTP webhook signing key.
  • If you put the API Key into the Mailgun HTTP transport settings, you can only send email without email tracking.
  • If you use the Webhook signing key, then email tracking works but sending communications causes an unauthorized error.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v14.3

Client Culture Setting

en-US

@nairdo
Copy link
Member

nairdo commented Dec 13, 2023

Thanks @mkinyon . We also discovered this late last week and have patches coming in Rock v14.4, v15.4, and v16.1.

[Update -- I should have also mentioned that it appears Mailgun semi-recently changed their UI which means both new customers and existing customers who recycle their keys will fall into this problem situation which requires the patch.]

@nairdo nairdo added Type: Enhancement Feature requests. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. Priority: High Affects most production Rock installs in a way that will be noticed. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. labels Dec 13, 2023
jasonhendee added a commit that referenced this issue Dec 13, 2023
…ook signing key" values within Mailgun integration. (Fixes #5694)
jasonhendee added a commit that referenced this issue Dec 13, 2023
…ook signing key" values within Mailgun integration. (Fixes #5694)

(cherry picked from commit bd2e772)

 Conflicts:
	Rock/Rock.csproj
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v14.4 Fixed in v15.4 Fixed in v16.1 Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Enhancement Feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants