Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection request activities list doesn't include activities from other person aliases #5759

Closed
2 tasks done
JRichmond27 opened this issue Feb 16, 2024 · 0 comments
Closed
2 tasks done
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@JRichmond27
Copy link

JRichmond27 commented Feb 16, 2024

Description

The Activities section on some connection requests only shows some of the activities from other requests for the same person.

All three of these screenshots came from different requests for the same person:

image
image
image

Notice that none of them show the same set of activities.

After some SQL queries, I discovered that the activities were segregated by requests with different PersonAliasId values for the same person. The Activities section is not gathering up all of the activities for the person. Instead it's only gathering the activities with the same PersonAliasId as the connection request that's currently being viewed.

Actual Behavior

The Activities sections on connection requests are only showing activities from other connection requests if the other request's PersonAliasId matches the PersonAliasId of the request that is currently being viewed.

Expected Behavior

The Activities section on a connection reqeust should show all of the activities from other requests for the same person, regardless of whether the person has multiple person alias records or which PersonAliasId is referenced on each request.

Steps to Reproduce

  1. Create two person records
  2. Create four new connection requests, two for each person
  3. Add at least one activity to each request
  4. Notice that the Activities section on each request only shows the activities for the same person
  5. Merge the two people together
  6. Check the Activities sections for each request again and notice that they still show the same list of activities that they showed before the merge, instead of showing ALL activities for the newly merged person.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.4 and 16.2

Client Culture Setting

en-US

@JRichmond27 JRichmond27 changed the title Connection request activites list doesn't include activites from other person aliases Connection request activities list doesn't include activities from other person aliases Feb 16, 2024
@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Feb 16, 2024
Kwame-Agyei added a commit that referenced this issue Feb 23, 2024
… Requests did not show activities from the requester's other aliases. (Fixes #5759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants