Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha 1.16.4.1] Obsidian Persisted Dataset Detail interval unit only changes if quantity is changed too #5795

Closed
2 tasks done
leahjennings opened this issue Mar 18, 2024 · 3 comments
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@leahjennings
Copy link
Collaborator

Description

When editing the time unit (mins / hours / days) of a persisted dataset refresh interval, changing only the time unit does not save. If you change only the time unit and some other setting (like checking or unchecking an enabled lava command) the changes do save as expected.

Actual Behavior

Changing only the time unit of a refresh interval does not save to the database.

Expected Behavior

I would expect to be able to change only the time unit of a persisted dataset and it save to the database.

Steps to Reproduce

  • On a Rock instance running v16.4 alpha (1.16.4.1), navigate to Admin Tools > CMS Configuration, then click on Persisted Datasets
  • Click on any persisted dataset in the list (or create a dummy one if none exist)
  • On the persisted dataset detail page, edit the Main page zone
  • Click to add a new block, and add the Obsidian version of the CMS block Persisted Dataset Detail
image
  • Delete the other block (or drag the Obsidian version to the top, either way, it doesn't matter)
image
  • Hit Done and refresh the page
  • Hit the Edit button on the Obsidian block
  • Scroll down and take note of the current interval (in this example, it is every 9 minutes)
image
  • Change just the Persistence Schedule time unit (i.e. Mins, Hours, or Days) but not the quantity (in this example, I am changing from 9 minutes to 9 hours)
image
  • Hit Save
  • Refresh the page
  • Note how the interval is still every 9 minutes
  • If you edit again and change both the quantity and unit, it will save accordingly

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 16.4 (1.16.4.1)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Mar 18, 2024
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Mar 25, 2024
@ryneld-tcc
Copy link

In testing this one still didn't work for me.

@chead4
Copy link

chead4 commented Apr 9, 2024

@ryneld-tcc Thanks for reaching out to us on this issue. I've tried to recreate this issue on v16.4 but am unable to do so. When editing the Persistence Schedule Interval time unit from Hours to Days on the Persisted Dataset Detail Obsidian block, the correct Interval time unit was displayed upon refreshing the page. Can you please let us know what version you are testing on?

@ryneld-tcc
Copy link

ryneld-tcc commented Apr 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants