Invalid Organisation address prevents maintenance of Family addresses

[ElimAdmin]

Change the Global Attributes, Organization Address State/Country combination to something invalid (e.g. change Country from US to New Zealand in the demo site) and you can no longer add or maintain addresses in Edit Family.

In my site I get this error with an invalid state for New Zealand:

In the demo site if the Organization Country is changed to New Zealand I get the following error message: "An unknown error occurred while processing the request on the server. The status code returned from the server was: 500"

The Country is not shown on the Organization address when viewing all Global Attributes - I suggest it should be.

If the Global Attributes 'Support International Address' is set to No - it is easy to get the State/Country combination for the Organization address wrong, because the Country is not shown on the Organization Address maintenance screen. Perhaps the Country should always be shown on this screen because it sets the default Country on added addresses.

The Organization Address screen should not be allowed to save if it is going to create errors when maintaining Family address, or the Family Address maintenance should not be affected by an invalid Organization address.

Consider adding the default Country (the country of the Organization Address) to the 'Support International Addresses' page for clarity? (This is where I expected to see it.)

This error was fixed by adding at least one State (Province) for New Zealand, and making sure that the Global Organization Address had the State correctly set.

Given that the default Rock ships with only US states loaded this will be a problem for other international users unless they are forced to add at least one State for their Country, and then they are forced to enter a valid State and Country combination. I seem to recall that the default 'Support International Address' setting is No - so if you go in and make changes to the Organizational Address and cannot see the Country (because of this flag hiding the Country) this will be an easy mistake to make.

(In fact, we don't use State/Province in New Zealand addresses, so it would be acceptable to leave this blank - but there is no way to load a 'null' value, so we will just used 'NZ' for all addresses.)

[MikeDPeterson]

I fixed up a couple of related issues that might have caused the other problems you were seeing. One was a ViewState error, and the other would result in the wrong state getting selected if Country was changed.

[ElimAdmin]

Thanks Mike

From: Mike Peterson [mailto:notifications@github.com]
Sent: Tuesday, 28 October 2014 11:16 a.m.
To: SparkDevNetwork/Rock
Cc: Ken Roach
Subject: Re: [Rock] Invalid Organisation address prevents maintenance of Family addresses (#587)

I fixed up a couple of related issues that might have caused the other problems you were seeing. One was a ViewState error, and the other would result in the wrong state getting selected if Country was changed.

—
Reply to this email directly or view it on GitHub #587 (comment) .