Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to add people to tags when viewing the tag details page #2875

Merged
merged 1 commit into from May 1, 2018

Conversation

cabal95
Copy link
Member

@cabal95 cabal95 commented Mar 15, 2018

Contributor Agreement

By contributing your code, you agree to license your contribution under the Rock Community License Agreement.

Context

What is the problem you encountered that lead to you creating this pull request?

Inability to add people directly to a tag without going to their profile page. See #556.

Goal

What will this pull request achieve and how will this fix the problem?

Grant ability to do so.

Strategy

How have you implemented your solution?

When viewing the members of a tag, if the tag entity type is a Person then the Add button becomes available in the action bar. Upon clicking a modal dialog opens with the person picker expanded by default and ready to type in a person's name. You can then either Save and it will close the modal or Save And Add and it will add the person and then re-open the drop down for typing another name.

Tests

If your code is a new method or function (that doesn't need a mock database or SqlServerTypes library) and can be Xunit tested see example be sure your pull request includes the corresponding unit tests in the Rock.Tests project. In all cases you MUST test your code before submitting a pull request.

Possible Implications

What could this change potentially impact? Are there any security considerations? Where could this potentially affect backwards compatibility?

Screenshots

Provide us some screenshots if your pull request either alters existing UI or provides new UI. Arrows and labels are helpful.

addbutton

dialog

Documentation

If your change effects the UI or needs to be documented in one of the existing user guides, please provide the brief write-up here:

Migrations

Should your pull request require a migration, please exclude the migration from the Rock.Migration project, but submit it in your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.

@azturner azturner merged commit fd1607f into SparkDevNetwork:develop May 1, 2018
@cabal95 cabal95 deleted the feature-dh-add-to-tag branch May 1, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants