Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue in Obsidian Registration Entry where group member attribute fields were not being resolved #5401

Conversation

Jon-Corey
Copy link
Contributor

@Jon-Corey Jon-Corey commented Apr 14, 2023

Notice

We cannot guarantee that your pull request will be accepted. There are many factors involved. We take into consideration whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request (since it may impact a part of the system you don't regularly use). Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock, are other important factors.

Proposed Changes

This fixes an issue where the Obsidian Registration Entry block was unable to display group member attribute fields. This meant that any group member attribute on a registration was not able to be filled out or edited. Instead of showing the field, the block would show an alert that said "Could not resolve field source 2".

This fixes that issue by adding the group member attribute field source to the list of supported field sources.

Screenshot of before this fix:
GroupMemberFieldsObsidianBlock

Screenshot of after this fix:
GroupMemberFieldsFixed

Fixes: #5398

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, which has been approved by the core team)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement
  • Unit tests pass locally with my changes
  • I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
  • I have included updated language for the Rock Documentation (if appropriate)

Further comments

Documentation

Migrations

@nairdo nairdo added PR Ready A change that's interesting to us, something we'd consider adding, and have assigned for review. PR Code Reviewed Indicates the code has been reviewed by the core team and smells normal. labels Apr 17, 2023
@ethan-sparkdevnetwork ethan-sparkdevnetwork merged commit 0ca27f3 into SparkDevNetwork:hotfix-1.14.3 Apr 17, 2023
@ethan-sparkdevnetwork
Copy link
Contributor

Thanks @Jon-Corey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Code Reviewed Indicates the code has been reviewed by the core team and smells normal. PR Ready A change that's interesting to us, something we'd consider adding, and have assigned for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants