Fixed an issue in Obsidian Registration Entry where the progress bar was using the wrong field for first name

[Jon-Corey]

Notice

We cannot guarantee that your pull request will be accepted. There are many factors involved. We take into consideration whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request (since it may impact a part of the system you don't regularly use). Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock, are other important factors.

Proposed Changes

This fixes an issue where the Obsidian Registration Entry block would use the value of the first field as the registrant's First Name in the progress bar instead of using the value of the First Name field.

This fixes this by adding an additional constraint to the function that finds the First Name field so that it can only find Person Fields.

Screenshot of before this fix (the value of the Text field is used as the first name on the progress bar):

Screenshot of after this fix (the value of the First Name field is used as the first name on the progress bar):

Fixes: #5400

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality, which has been approved by the core team)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• This is a single-commit PR. (If not, please squash your commit and re-submit it.)
• I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
• I have read the Contributing to Rock doc
• By contributing code, I agree to license my contribution under the Rock Community License Agreement
• Unit tests pass locally with my changes
• I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
• I have included updated language for the Rock Documentation (if appropriate)

Further comments

Documentation

Migrations

┆Attachments: image.png

[ethan-sparkdevnetwork]

Good find @Jon-Corey.