Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on ScheduleTransactionEditV2 block #5589

Closed
wants to merge 1 commit into from

Conversation

taylorbrooks
Copy link
Contributor

@taylorbrooks taylorbrooks commented Sep 11, 2023

Proposed Changes

  • Ensure ReferenceNumber is set on referencePaymentInfo (see old block functionality)
  • Only clear payment info if a new payment method is added

Fixes: #5585

Types of changes

What types of changes does your code introduce to Rock?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • This is a single-commit PR. (If not, please squash your commit and re-submit it.)
  • I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
  • I have read the Contributing to Rock doc
  • By contributing code, I agree to license my contribution under the Rock Community License Agreement

Only clear payment info if a new payment method is added
@taylorbrooks taylorbrooks changed the title Fix bugs on ScheduleTransactionEditV2 block Fix issues on ScheduleTransactionEditV2 block Sep 11, 2023
@nairdo
Copy link
Member

nairdo commented Sep 14, 2023

Hi @taylorbrooks We're addressing the #5585 issue in a slightly different manner via e833f01 .

@nairdo nairdo closed this Sep 14, 2023
@taylorbrooks
Copy link
Contributor Author

@nairdo Thanks Nick!

Is there going to be any more versions for v15 cut? It would be awesome to have this change included in the v15 line as well as the v16 line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FinancialPaymentDetail Fields are Nullified when using ScheduledTransactionEditV2
2 participants