Fix multiple plugin load #1126
Fix multiple plugin load #1126
Conversation
|
Ok, this method makes no sense. And yes, this can lead to double initialization of Plugins. |
|
@vitezp Could you fix https://github.com/techtalk/SpecFlow/blob/master/TechTalk.SpecFlow/Configuration/AppConfig/AppConfigConfigurationLoader.cs#L115 & https://github.com/techtalk/SpecFlow/blob/master/TechTalk.SpecFlow/Configuration/JsonConfig/JsonConfigurationLoader.cs#L97 In that case writing some tests for it are also possible. Thanks for finding this! |
|
Added check which won't allow adding the plugin which is already in the list of plugins to load. For both Json and AppConfig configurations. |
|
resolves #888 |
* Fix return type of GetPlugins method to prevent loading multiple plugins * added to changelog * Check if plugin to add is in list of plugins for json and appconfig * adding unit tests to check loading multiple same plugins
|
Nice work, seeing as this is merged to master will this be in the next Specflow release? Sorry if it's obvious, not all that familiar with Github. |
|
@yesiamtom yes, this will be in the next SpecFlow release. But there is not yet a timeframe when it will get released. |
|
Is there any news on when the next Specflow version will be released with this fix? |
|
@Hamels no, but you can use the packages from our CI feed: https://ci.appveyor.com/nuget/specflow-ci |
According to #888 there were multiple users having the same problem.
Problem was that plugins are once loaded from app.config and then it loads configuration through method LoadConfiguration which calls the same loading method. This results in the same plugin being in the collection twice. Some Equals method together with distinct should resolve the issue but this is IMO more elegant way.
This simple one-liner should resolve the issue as it does in my simulated environment.
Types of changes
Checklist: