Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust parameter names generation (#1694) #1753

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Adjust parameter names generation (#1694) #1753

merged 2 commits into from
Oct 23, 2019

Conversation

spirit11
Copy link
Contributor

@spirit11 spirit11 commented Oct 14, 2019 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the changelog

SabotageAndi
SabotageAndi suggested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@SabotageAndi SabotageAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the small change, it looks good.
Please also add an entry to the changelog. Then I will merge the PR. Thanks for it!

TechTalk.SpecFlow.Generator/Generation/UnitTestMethodGenerator.cs Outdated
@@ -345,6 +345,26 @@ private ParameterSubstitution CreateParamToIdentifierMapping(ScenarioOutline sce
paramToIdentifier.Add(param.Value, param.Value.ToIdentifierCamelCase());
}

//fix empty parameters
var emptyStrings = paramToIdentifier.Where(kv => kv.Value == "").ToArray();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use String.Emtpy for ""

@SabotageAndi SabotageAndi merged commit 86bf8db into SpecFlowOSS:master Oct 23, 2019
@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

@SabotageAndi SabotageAndi mentioned this pull request Oct 23, 2019
Closed
32 tasks
@spirit11 spirit11 deleted the issue_1694 branch October 23, 2019 18:20
idg10 pushed a commit to idg10/SpecFlow that referenced this pull request Jan 8, 2020
@spirit11 @idg10
Adjust parameter names generation (SpecFlowOSS#1694) (SpecFlowOSS#1753)
e96bb2f 
* Adjust parameter names generation (SpecFlowOSS#1694)

* changelog entry added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabotageAndi SabotageAndi SabotageAndi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spirit11 @SabotageAndi