Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skeleton template #1908

Merged
merged 3 commits into from Mar 18, 2020

Conversation

dannyBies
Copy link
Contributor

Update the default C# skeleton template to use context injection instead of the deprecated ScenarioContext.Current. I have only updated the C# skeleton and not the VB one as I'm not familiar with VB. Would gladly add this if someone knows what the VB variant should look like.

I also haven't added any tests. I don't believe there are currently any tests that cover the actual skeleton templates. If this should be covered under tests please point me in the right direction :).

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SabotageAndi
Copy link
Contributor

Thanks for the change.
Sadly this changes nothing what the Visual Studio Extension is generating. The Visual Studio Extension is using an old SpecFlow 1.9 version. It is not calling into the version that is used in a project.

I will merge this so that we have it when we some time in the future update the SpecFlow version in the VS Extension.

@SabotageAndi SabotageAndi merged commit a7e2374 into SpecFlowOSS:master Mar 18, 2020
@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

@RampouchCZ
Copy link

@SabotageAndi Hi, sorry to hijack this thread, but do you know about any plans of updating VS extension with new specflow so we can use new templates? If there are no plans for it now, I might try to give it a go.

@SabotageAndi
Copy link
Contributor

@McRampaCZ one of our team is trying currently to update the SpecFlow version in the extension. We are still not sure if this is possible within a reasonable effort. And he invested already 4-5 days into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants