Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skeleton template #1908

Merged
merged 3 commits into from Mar 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Expand Up @@ -18,7 +18,7 @@



- [ ] I've added tests for my code. (most of the time mandaory)
- [ ] I've added tests for my code. (most of the time mandatory)
- [ ] I have added an entry to the changelog. (mandatory)
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
Expand Up @@ -7,20 +7,26 @@ namespace {namespace}
[Binding]
public class {className}
{
private readonly ScenarioContext _scenarioContext;

public {className}(ScenarioContext scenarioContext)
{
_scenarioContext = scenarioContext;
}
{bindings}
}
}
>>>CSharp/StepDefinitionRegex
[{attribute}(@"{regex}")]
public void {methodName}({parameters})
{
ScenarioContext.Current.Pending();
_scenarioContext.Pending();
}
>>>CSharp/StepDefinition
[{attribute}]
public void {methodName}({parameters})
{
ScenarioContext.Current.Pending();
_scenarioContext .Pending();
}
>>>VB/StepDefinitionClass
Imports System
Expand Down
6 changes: 6 additions & 0 deletions changelog.txt
@@ -1,9 +1,15 @@
Changes since 3.1.89

Fixes:
+ Update the default C# skeleton template to use context injection instead of the deprecated ScenarioContext.Current

Changes since 3.1.86

Fixes:
+ Replace NUnit.Framework.DescriptionAttribute to TestName in NUnit generator #1225
+ Import MSBuild Tasks only once (fixes https://github.com/SpecFlowOSS/SpecFlow/issues/1699)


3.1 - 2020-01-09

Features:
Expand Down