Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of custom subclasses of StepDefinitionBaseAttribute. #1938

Merged
merged 1 commit into from
May 5, 2020
Merged

Allow the use of custom subclasses of StepDefinitionBaseAttribute. #1938

merged 1 commit into from
May 5, 2020

Conversation

dnperfors
Copy link
Contributor

@dnperfors dnperfors commented Apr 2, 2020

These changes allow for creation and usage of custom stepdefinition attributes like:

public class GivenAndWhenAttribute : StepDefinitionBaseAttribute
{
    public GivenAndWhenAttribute(string regex)
        : base(regex, new[] { StepDefinitionType.Given, StepDefinitionType.When })
    {
    }
}

Closes #1932

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow. Sorry, that it took us so long to merge this PR.
I updated the changelog to the current state.

If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow creating custom GivenAndWhenAttribute
2 participants