Fix step definition attribute support for the Visual Studio Extension #2065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generalization and simplifications of the handling of step definition attributes in #1938 break the analysis of the bindings in the Visual Studio Extension. In the Visual Studio Extension the step definition attributes are analyzed from the source code of the binding classes. Hence the binding reflection is not based on compiled/runtime types.
The
TechTalk.SpecFlow.Bindings.Reflection.IBindingType
instances returned by the Visual Studio Extension are notRuntimeBindingTypes
and do not implement theIPolymorphicBindingType
interface. As long as the extension works with source code constructs in the binding analysis this has to be taken into account.The usage of the extension method
BindingReflectionExtensions.IsAssignableFrom
can be especially misleading, because it looks very similar to aSystem.Type.IsAssignableFrom
call, but the semantics are not the same. Especially if the IBindingType is not an IPolymorphicBindingType, because then the extension method only compares the FullName of the types without being able to take polymorphism/inheritance into account.Types of changes
Checklist: