Corrected adapt functions for Grids, Models, ParameterStructs and SpectralTransform #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt functions for the updated Grids files.
New PR for the adapt functions for models.jl, parameter_structs.jl and spectral_transform.jl.
…Structs Adapt functions for the newest versions of models.jl and spectral_transform.jl as well as parameter_structs.jl.
|
@katharinamaetschke please note #241, the grids are now moved to src/RingGrids in a submodule RingGrids, similar for LowerTriangularMatrix in src/LowerTriangularMatrices and SpeedyTransforms in src/SpeedyTransforms to give everything more structure. |
|
@maximilian-gelbrecht is this actually superceded now? |
|
Yes, let's close it. We have to adjust it to the new structure in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the adapt functions for the new Grid files in the way that Milan suggested and also uploaded the Models.jl, Parameter_structs.jl and spectral_transform.jl files again, since I closed the last PR for these.