fix: fixed some issue in the IssuerMetadataUtils plus added some unit…

…tests for it

packages/common/lib/__tests__/IssuerMetadataUtils.spec.ts

@@ -0,0 +1,38 @@
+import { getTypesFromCredentialSupported } from '../functions';
+import { CredentialConfigurationSupportedV1_0_13 } from '../types';
+
+describe('IssuerMetadataUtils should', () => {
+  it('return the types from a credential supported with jwt_vc_json format', () => {
+    const credentialSupported: CredentialConfigurationSupportedV1_0_13 = {
+      format: 'jwt_vc_json',
+      credential_definition: {
+        type: ['VerifiableCredential', 'BevoegdheidUittreksel'],
+      },
+    };
+
+    const result: string[] = getTypesFromCredentialSupported(credentialSupported);
+    expect(result).toEqual(['VerifiableCredential', 'BevoegdheidUittreksel']);
+  });
+
+  it('filter out "VerifiableCredential" type if filterVerifiableCredential option is true', () => {
+    const credentialSupported: CredentialConfigurationSupportedV1_0_13 = {
+      format: 'jwt_vc_json',
+      credential_definition: {
+        type: ['VerifiableCredential', 'BevoegdheidUittreksel'],
+      },
+    };
+
+    const result: string[] = getTypesFromCredentialSupported(credentialSupported, { filterVerifiableCredential: true });
+    expect(result).toEqual(['BevoegdheidUittreksel']);
+  });
+
+  it('throw an error if types cannot be deduced', () => {
+    const credentialSupported: CredentialConfigurationSupportedV1_0_13 = {
+      format: 'unknown_format',
+    } as unknown as CredentialConfigurationSupportedV1_0_13;
+
+    expect(() => {
+      getTypesFromCredentialSupported(credentialSupported);
+    }).toThrow('Could not deduce types from credential supported');
+  });
+});

packages/common/lib/functions/IssuerMetadataUtils.ts

@@ -46,25 +46,26 @@ export function getSupportedCredential(opts?: {
     return {};
   }
 
-  const configurationIds: string[] = Object.keys(issuerMetadata.credential_configurations_supported);
+  const credentialConfigurations: Record<string, CredentialConfigurationSupportedV1_0_13> =
+    issuerMetadata.credential_configurations_supported as Record<string, CredentialConfigurationSupportedV1_0_13>;
   const normalizedTypes: string[] = Array.isArray(types) ? types : types ? [types] : [];
   const normalizedFormats: string[] = Array.isArray(format) ? format : format ? [format] : [];
 
-  return configurationIds.reduce((filteredConfigs, id) => {
-    const config = (issuerMetadata.credential_configurations_supported as Record<string, CredentialConfigurationSupportedV1_0_13>)[id];
+  return Object.entries(credentialConfigurations).reduce(
+    (filteredConfigs, [id, config]) => {
+      const isTypeMatch = normalizedTypes.length === 0 || normalizedTypes.some((type) => config.credential_definition.type.includes(type));
+      const isFormatMatch = normalizedFormats.length === 0 || normalizedFormats.includes(config.format);
 
-    const isTypeMatch = normalizedTypes.length === 0 || normalizedTypes.includes(id);
-    const isFormatMatch = normalizedFormats.length === 0 || normalizedFormats.includes(config.format);
-
-    if (isTypeMatch && isFormatMatch) {
-      filteredConfigs[id] = config;
-    }
+      if (isTypeMatch && isFormatMatch) {
+        filteredConfigs[id] = config;
+      }
 
-    return filteredConfigs;
-  }, {} as Record<string, CredentialConfigurationSupportedV1_0_13>);
+      return filteredConfigs;
+    },
+    {} as Record<string, CredentialConfigurationSupportedV1_0_13>,
+  );
 }
 
-
 export function getTypesFromCredentialSupported(
   credentialSupported: CredentialConfigurationSupported,
   opts?: { filterVerifiableCredential: boolean },