Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any values for the format.ldp_vc.proof_type #134

Open
TimoGlastra opened this issue Jan 9, 2024 · 1 comment
Open

Allow any values for the format.ldp_vc.proof_type #134

TimoGlastra opened this issue Jan 9, 2024 · 1 comment

Comments

@TimoGlastra
Copy link
Contributor

Currently the allowed values for the proof_type from ldp_vc format is restricted to a set of known types, namely:

    return [
      'Ed25519VerificationKey2018',
      'Ed25519Signature2018',
      'RsaSignature2018',
      'EcdsaSecp256k1Signature2019',
      'EcdsaSecp256k1RecoverySignature2020',
      'JsonWebSignature2020',
      'GpgSignature2020',
      'JcsEd25519Signature2020',
      'BbsBlsSignature2020',
      'Bls12381G2Key2020',
    ];

Is there a specific reason for this. As PEX doesn't handle the signature stuff, it could support any proof types and it would make the PEX library more flexible towards future signature suites that have yet to be defined.

@nklomp
Copy link
Contributor

nklomp commented Jan 9, 2024

Reason is (if I remember correctly), that we have OpenAPI specs for the actual models (and endpoints for REST), allowing to limit this. But agree it probably make sense to either make this extensible or just use a string.

Will be updated ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants