New dependency notation base API #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfayard
changed the title
jmfayard
force-pushed
the
draft-kodein-di
branch
from
83711df
to
3699300
Compare
jmfayard
force-pushed
the
draft-kodein-di
branch
from
3699300
to
afaec2e
Compare
Co-Authored-By: Louis CAD <louis.cognault@gmail.com>
Co-Authored-By: Louis CAD <louis.cognault@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
This will allow less code to run if assertions are disabled Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
It now takes into account new dependency notations merged from the main branch. Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
Co-authored-by: Jean-Michel Fayard <jmfayard@gmail.com>
…12.0 # Conflicts: # plugins/dependencies/src/test/resources/bundled-dependencies-validated.txt
This way the user can always fix the value of platform constraints Http4k.usePlatformConstraints = true / false And we can auto-enable usePlatformConstraints when the bill of materials is used. See Http4k.bom
|
@LouisCAD I have updated the branch with the new API It would be nice if you can prioritize reviewing this pull request, it has diverged from main since too much time, and it would be much easier to accept pull requests like #387 #389 once it's merged |
LouisCAD
reviewed
Aug 4, 2021
LouisCAD
reviewed
Aug 4, 2021
Co-authored-by: Louis CAD <louis.cognault@gmail.com>
We know it doesn't compile. Co-authored-by: Louis CAD <louis.cognault@gmail.com>
Also disable the error check inside the tests
jmfayard
force-pushed
the
draft-kodein-di
branch
from
a48e0ab
to
f808089
Compare
jmfayard
force-pushed
the
draft-kodein-di
branch
from
7dba0b8
to
3b23788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #352
See dependencies suggestions #238