Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forge Mod Support #510

Open
1 of 2 tasks
phase opened this issue Mar 17, 2018 · 2 comments · May be fixed by #949
Open
1 of 2 tasks

Forge Mod Support #510

phase opened this issue Mar 17, 2018 · 2 comments · May be fixed by #949
Assignees
@phase
Labels
component: platform Platforms like Sponge / Forge type: enhancement
Milestone
v2.0.0-M3

Comments

@phase
Copy link
Contributor

phase commented Mar 17, 2018 •
edited
Loading

Forge tags exist for Sponge plugins that have Forge as a dependency, but standalone Forge mod support is limited.

  • Forge Tag
  • Get Minecraft Version and add a Minecraft Version tag
@phase phase added this to the v1.7.0 milestone Mar 17, 2018
@phase phase self-assigned this Mar 17, 2018
@phase phase mentioned this issue Mar 17, 2018
Merged
@phase
Copy link
Contributor Author

phase commented Mar 28, 2018

Some plugins like to override the generation of the mcmod.info file with their own. Currently, mods and plugins like this won't appear with any tags. I think they should be rejected, as we're unable to determine what platform the mod is for.

@progwml6
Copy link
Member

the other option is to use ASM to find the forge/sponge mod annotations on upload, however ... i'd rather avoid doing this, as i don't want to be scanning for this if 1.13 fml changes break the current setup

@phase phase mentioned this issue Apr 19, 2018
Closed
@phase phase mentioned this issue Aug 20, 2018
Merged
@phase phase added component: platform Platforms like Sponge / Forge and removed component: backend labels Aug 21, 2018
@Katrix Katrix modified the milestones: v2.0.x, v2.0.0-M3 Nov 18, 2020
@Katrix Katrix linked a pull request Nov 20, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phase phase

Labels
component: platform Platforms like Sponge / Forge type: enhancement
Projects
None yet
Milestone
v2.0.0-M3
Development

Successfully merging a pull request may close this issue.

Vue frontend for Project area (and other stuff) SpongePowered/Ore
3 participants
@progwml6 @phase @Katrix