Implement SizeData #1492
Closed
Implement SizeData #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I can go ahead and fix these merge conflicts sometime today or tomorrow. If anyone would like to see any other changes please bring them up. |
kashike
suggested changes
Sep 9, 2017
| public ImmutableSpongeSizeData(float base, float height, float scale) { | ||
| super(ImmutableSizeData.class); | ||
|
|
||
| checkArgument(scale > 0, "The base size must be greater than 0."); |
parlough
force-pushed
the
feature/size-data
branch
from
f9dd68a
to
7b02faa
Compare
|
This will need to be re-done and re-target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
Supersedes #402
Implements size data based on Hassan's changes, but with some changes to the API and implementation, including the inclusion of a modified version of his test plugin.
With this PR you can modify the base_size(width) and height, but developers have to keep in mind that this only changes the bounding box, it isn't super reliable, and Sponge(maybe Minecraft idk) limits the max size of a bounding box to 1000.
I am open to changes everywhere, from documentation to functionality, so please give this a good review.