-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some changes for size data #1636
Conversation
Oh man this is embarrassing one second |
0a1949f
to
45ddacc
Compare
These should be good for a final review/test with the fixes I made last night. |
Looking for considerations on changing |
I had to guess that "base" is supposed to affect "width". There seems to be an inconsistence with Entity#getBoundingBox where this method already returns AABB, but size data rely on "base" and "height" - two flaot params. |
Can't entities just use any aabb for their shapes? |
@parlough Can you change the use of |
SpongeAPI | SpongeCommon
This PR makes some changes to SizeData as the keys were mutable bounded values but the data manipulator methods were just values. I also modified some documentation about how modifying these can not always work as intended.
Please read the common PR for more information and provide as much feedback as possible on documentation and functionality.