Add missing data to "supplyVanillaManipulators" methods for entities #2493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully (with some exceptions) implements methods such as
Entity#getValues()
,Entity#getKeys()
,Entity#getContainers()
.Some keys were simply not implemented (PRs implementing them were canceled due to the closing of the bleeding branch), which means that they are in principle not available in official Sponge implementations:
Keys.BASE_SIZE
,Keys.HEIGHT
,Keys.SCALE
) — Implement SizeData #1492Keys.IS_SLEEPING
,Keys.IGNORE_SLEEPING
) — Implement SleepingData and IgnoreSleepingData #1488Just unimplemented data:
Keys.ATTACK_DAMAGE
,Keys.DAMAGE_ENTITY_MAP
)Keys.WILL_SHATTER
)And some just don't have a
DataManipulator
:Keys.LLAMA_STRENGTH
,Keys.LLAMA_VARIANT
)