Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add world save mode for ServerWorld#save() to support flush #3688

Open
wants to merge 2 commits into
base: api-10
Choose a base branch
from
Open

Add world save mode for ServerWorld#save() to support flush #3688

wants to merge 2 commits into from

Conversation

Lignium
Copy link
Contributor

@Lignium Lignium commented May 17, 2022 •
edited

SpongeAPI | Sponge

@Lignium Lignium mentioned this pull request May 17, 2022
Open
@Lignium Lignium force-pushed the feature/improve-save branch 2 times, most recently from e012fbc to 806bf13 Compare August 23, 2022 14:52
ImMorpheus
ImMorpheus requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@ImMorpheus ImMorpheus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes in behaviour with serialization behaviour and events that seem unrelated to this PR.

...ins/java/org/spongepowered/common/mixin/api/minecraft/server/level/ServerLevelMixin_API.java Outdated Show resolved Hide resolved
src/mixins/java/org/spongepowered/common/mixin/core/server/level/ServerLevelMixin.java Outdated Show resolved Hide resolved
aromaa
aromaa requested changes Jan 21, 2023
View reviewed changes
Copy link
Member

@aromaa aromaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the fixes to the SerializationBehavior logic in 3a371bb that were discussed on Discord.

We can take a look at how the events should be fired on api-10 but for api-8 it would be a breaking change.

@Lignium Lignium requested a review from aromaa January 21, 2023 16:25
@ImMorpheus ImMorpheus added api: pending the API is not finished (input wanted, etc.) version: 1.16 (u) API: 8 labels Jan 28, 2023
@Lignium Lignium changed the base branch from api-8 to api-10 June 9, 2023 18:04
@aromaa aromaa added version: 1.19 API: 10 and removed version: 1.16 (u) API: 8 labels Jun 12, 2023
@gabizou gabizou force-pushed the api-10 branch 2 times, most recently from 5825843 to 1c4ba14 Compare January 16, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImMorpheus ImMorpheus ImMorpheus requested changes

@aromaa aromaa Awaiting requested review from aromaa

Assignees
No one assigned
Labels
api: pending the API is not finished (input wanted, etc.) version: 1.19 API: 10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lignium @aromaa @ImMorpheus