MPRIS PlayerStatus always returning "Stopped"

[mainrs]

It looks like the Connect API returns the SHA-1 encoded device_name instead of the raw one. We compare it to the unhashed version. And since that will always fail, the PlayerStatus will always be Stopped.

I am, however, sure that it worked some releases ago 🤔

Relevant lines:

spotifyd/src/dbus_mpris.rs

Line 344 in 6c2fec5

if player.device.id == _device.unwrap() {

player.device.id is the hash, _device.unwrap() is the URL-encoded device name.

spotifyd/src/config.rs

Line 451 in 6c2fec5

fn device_id(name: &str) -> String {

To implement this, the above method should probably be moved to utils.rs

[stuarth]

I'll take this one!

[hifiberry]

Just had a look and it seems it also doesn't work on 0.2.10 anymore as it was some days ago. Might be a change in the API.

[mainrs]

That was my guess too. The online API does mention the hash though but I didn't check Google cache or the web archive for an older version.

[mainrs]

Just checked archive.org's fetches of the API page but even in 2017 the device_id is the hash of the device's name. Looks like my brain is tricking me...
This would mean that the PlayingStatus property actually never ever worked :(

Edit: Ups...

[mainrs]

@stuarth FYI, https://github.com/ramsayleung/rspotify/blob/master/src/spotify/model/device.rs#L5 is the struct returned by player.device. It has a name field. So it might be enough to compare to player.device.name instead of player.device.id. You might need to url-encode the String in player.device.name as I have no clue if it is encoded or not.

[stuarth]

@sirwindfield Thanks! Looking into it now