Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module can be used in its own definition [FUTURE BUG] #6

Closed
justanothercell opened this issue Jan 28, 2023 · 1 comment
Closed

Module can be used in its own definition [FUTURE BUG] #6

justanothercell opened this issue Jan 28, 2023 · 1 comment
Labels
bug Something isn't working simulator-bug bugs/non-working functions in the simulator

Comments

@justanothercell
Copy link

Issue

A module being used in its own definition could lead to infinite recursion.
Note that this is potentially not true for all configurations.
I has to be checked recursively for modules using modules that use the current module
(aka recursion where the loop is larger than 1 element)
image
@justanothercell justanothercell changed the title Module can be used in its own definition Module can be used in its own definition [FUTURE BUG] Jan 28, 2023
@Spydr06 Spydr06 added bug Something isn't working simulator-bug bugs/non-working functions in the simulator labels Jan 28, 2023
@Spydr06
Copy link
Owner

Spydr06 commented Mar 11, 2023

Fixed by having an error reported to the user when recursion is detected

@Spydr06 Spydr06 closed this as completed Mar 11, 2023
toadkarter added a commit to toadkarter/logicrs that referenced this issue Oct 8, 2023
@toadkarter
parent 3b28ab6
97294ab 
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751330 +0100

parent 3b28ab6
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751324 +0100

# This is the 1st commit message:

Adds serialized settings file that saves theme state.

# This is the commit message Spydr06#2:

#Adding functionality for saving theme to config file.

# This is the commit message Spydr06#3:

#Loading custom theme if a new window has been created.

# This is the commit message Spydr06#4:

#Setting initial radio button state to what is in the settings when loading Theme.

# This is the commit message Spydr06#5:

#Changing settings file to save in the OS specific config directory.

# This is the commit message Spydr06#6:

#Adding Fedora dependencies to Readme.

# This is the commit message Spydr06#7:

#adding code of conduct

# This is the commit message Spydr06#8:

#edit code of conduct

# This is the commit message Spydr06#9:

#edit code of conduct

# This is the commit message Spydr06#10:

#chore: made Rust CI workflow
# This is the commit message Spydr06#11:

#added explanatory comments to rust_ci.yml
# This is the commit message Spydr06#12:

#updated checkout action

# This is the commit message Spydr06#13:

#used official cargo deny action

# This is the commit message Spydr06#14:

#use nightly toolchain

# This is the commit message Spydr06#15:

#Update INSTALL.md
# This is the commit message Spydr06#16:

#Bump version number
# This is the commit message Spydr06#17:

#Bump version number to `0.1.2`
# This is the commit message Spydr06#18:

#new examples

# This is the commit message Spydr06#19:

#Add macos install instructions
# This is the commit message Spydr06#20:

#ci: added libadwaita build steps to get CI jobs working

# This is the commit message Spydr06#21:

#added nsi script

# This is the commit message Spydr06#22:

#changed directories

# This is the commit message Spydr06#23:

#added relative path

# This is the commit message Spydr06#24:

#Delete nsi script directory
# This is the commit message Spydr06#25:

#Implement mux and demux

# This is the commit message Spydr06#26:

#add docs for mux, demux

# This is the commit message Spydr06#27:

#cargo fmt

#fix clippy issues

encoder decoder examples

fix CI issues with `cargo audit` and `cargo deny`

improve rendering of connection being drawn

add d flip flop, d latch, fix t flip flop

Fix examples, add q and !q to flip flops

Add docs for flip flops

run cargo fmt

fix macos shortcuts

Update README.md

cmd+backspace for deletion on mac

Add build instructions for libadwaita

Fixing up imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working simulator-bug bugs/non-working functions in the simulator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Spydr06 @justanothercell