Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows installer #20

Closed
Spydr06 opened this issue Sep 13, 2023 · 8 comments
Closed

Windows installer #20

Spydr06 opened this issue Sep 13, 2023 · 8 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@Spydr06
Copy link
Owner

Spydr06 commented Sep 13, 2023

Add an installer .exe (or .msi (?)) file to the releases that installs logicrs and some example projects automatically on Windows targets.

Currently, logicrs is distributed via portable .zip files
@Spydr06 Spydr06 added enhancement New feature or request hacktoberfest labels Sep 13, 2023
@VoidVampire
Copy link
Contributor

How do you want the installer to work? NSIS creates a basic exe.
After running the final exe, it will ask where to install, which upon selecting the folder will just extract the contents of the portable zip you provided in that directory , from where the user would have to click on the shortcut to run the exe.

I think this suits this particular application, although if there's a workaround for not using shortcut and placing exe in the root directory of project instead of in /bin, it would be great.

@Spydr06
Copy link
Owner Author

Spydr06 commented Oct 2, 2023

I think this suits this particular application, although if there's a workaround for not using shortcut and placing exe in the root directory of project instead of in /bin, it would be great.

Yes it would be better, it's currently like this because I couldn't figure out how to add a DLL include path for the .exe file... I don't use windows much :P

An NSIS installer sounds good to me 👍

@VoidVampire
Copy link
Contributor

VoidVampire commented Oct 2, 2023 •
edited
Loading

Got it. Am I allowed to add Releases for others repository under a PR? I can't find the directory to upload the exe file to 😓 . Should I share a gdrive link for exe if it's not possible through PR?

Also, since this is a small app, do you want to keep LICENSE in the exe? I am not sure how licenses work for such case.
I think I should keep README and remove .gitignore, what do you think about it?

@Spydr06
Copy link
Owner Author

Spydr06 commented Oct 2, 2023

If I remember correctly, there is some sort of configuration file for NSIS, upload that one, I can then generate the installers every release.

Yes, the LICENSE file stays, it is important. README can stay too, maybe even the DOCS.md file, .gitignore doesn't have to

@VoidVampire
Copy link
Contributor

Understood. For now, I have made a script for NSIS which will create exe "logicrs-windows-x86_64.exe". When double clicked, it will create a folder "logicrs" within the current directory and within that install all the files. I have tested it and I can run the app. Will this work?

@Spydr06
Copy link
Owner Author

Spydr06 commented Oct 2, 2023

Probably yes, submit a PR and I can test it myself

@VoidVampire VoidVampire mentioned this issue Oct 2, 2023
Merged
@VoidVampire
Copy link
Contributor

VoidVampire commented Oct 3, 2023 •
edited
Loading

oh btw do we still need this issue to be open, just curious @Spydr06 (cuz macos one seems to be closed 😓 )

@Spydr06
Copy link
Owner Author

Spydr06 commented Oct 4, 2023

No, just forgot to close it

@Spydr06 Spydr06 closed this as completed Oct 4, 2023
toadkarter added a commit to toadkarter/logicrs that referenced this issue Oct 8, 2023
@toadkarter
parent 3b28ab6
97294ab 
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751330 +0100

parent 3b28ab6
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751324 +0100

# This is the 1st commit message:

Adds serialized settings file that saves theme state.

# This is the commit message Spydr06#2:

#Adding functionality for saving theme to config file.

# This is the commit message Spydr06#3:

#Loading custom theme if a new window has been created.

# This is the commit message Spydr06#4:

#Setting initial radio button state to what is in the settings when loading Theme.

# This is the commit message Spydr06#5:

#Changing settings file to save in the OS specific config directory.

# This is the commit message Spydr06#6:

#Adding Fedora dependencies to Readme.

# This is the commit message Spydr06#7:

#adding code of conduct

# This is the commit message Spydr06#8:

#edit code of conduct

# This is the commit message Spydr06#9:

#edit code of conduct

# This is the commit message Spydr06#10:

#chore: made Rust CI workflow
# This is the commit message Spydr06#11:

#added explanatory comments to rust_ci.yml
# This is the commit message Spydr06#12:

#updated checkout action

# This is the commit message Spydr06#13:

#used official cargo deny action

# This is the commit message Spydr06#14:

#use nightly toolchain

# This is the commit message Spydr06#15:

#Update INSTALL.md
# This is the commit message Spydr06#16:

#Bump version number
# This is the commit message Spydr06#17:

#Bump version number to `0.1.2`
# This is the commit message Spydr06#18:

#new examples

# This is the commit message Spydr06#19:

#Add macos install instructions
# This is the commit message Spydr06#20:

#ci: added libadwaita build steps to get CI jobs working

# This is the commit message Spydr06#21:

#added nsi script

# This is the commit message Spydr06#22:

#changed directories

# This is the commit message Spydr06#23:

#added relative path

# This is the commit message Spydr06#24:

#Delete nsi script directory
# This is the commit message Spydr06#25:

#Implement mux and demux

# This is the commit message Spydr06#26:

#add docs for mux, demux

# This is the commit message Spydr06#27:

#cargo fmt

#fix clippy issues

encoder decoder examples

fix CI issues with `cargo audit` and `cargo deny`

improve rendering of connection being drawn

add d flip flop, d latch, fix t flip flop

Fix examples, add q and !q to flip flops

Add docs for flip flops

run cargo fmt

fix macos shortcuts

Update README.md

cmd+backspace for deletion on mac

Add build instructions for libadwaita

Fixing up imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Spydr06 @VoidVampire