Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploader uploads all cartidges on every file change #55

Closed
martijnpoppen opened this issue Sep 15, 2017 · 5 comments
Closed

Uploader uploads all cartidges on every file change #55

martijnpoppen opened this issue Sep 15, 2017 · 5 comments

Comments

@martijnpoppen
Copy link

martijnpoppen commented Sep 15, 2017

When i use the uploader to upload my changes to my sandbox it uploads all my cartridges.

Before i use dwupload with gulp. When i added watch to that command it uploaded only the individual file. Is something like that possible for the prophet uploader? Would be nice!

Gulp example:
screen shot 2017-09-15 at 10 51 03

@SqrTT
Copy link
Owner

SqrTT commented Sep 15, 2017

Hi @martijnpoppen
Not sure if I understood the question correctly. Flow is simple. When editor starts is check if upload is enabled, if so check if extension.prophet.clean.on.start is set to true then uploads all cartridges if no skips cartridges upload, after that starts watching files on disk.

Recap:

  • upload and watch is started if extension.prophet.upload.enabled set to true
  • skip initial cartridge upload on start if extension.prophet.clean.on.start set to false (default is true)

Regards,
Anatolii

@martijnpoppen
Copy link
Author

Hi @SqrTT ,
Yes thats correct. But the watch task watches single files. But when the file changes it uploads all the carttridges. (so the complete .zip).
So it's really slow when you have a big carttridge.

For me it would be really nice if only the file i changed will be uploaded.

With dwupload it's already possible (as i showed you in the image)

@SGD1953
Copy link
Contributor

SGD1953 commented Sep 15, 2017

That should not be the case, it uploads the cartridges initially and then the single files. That's also what it does for me. In case of an error it will fall back to upload the entire cartridge, maybe that is what's happening in your case.

@SqrTT
Copy link
Owner

SqrTT commented Sep 15, 2017

well, extension watch for changes and uploads single file.

image

If you face with another behaviour probably some error happened,

@martijnpoppen
Copy link
Author

Thanks for your comments.
I found my issue. My cartridge root was set to the folder above my cartridges folder. So i changed the root to the cartridges folder and it works!

Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants