Dv2 working #53
Merged
Dv2 working #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dv2 working
@Squatnet have a ganders ref https://github.com/FastLED/FastLED/wiki/RGBSet-Reference purpose is to create an array containing a pointer to each of the led strips (ie ledsA ledsB ect.) so that i can iterate through all the strips available to a device without having to break it down into multiple if/else statements.
…ncorrectly setting toSendID to 0
…send Fixed sendGroupMessage sending to 0
…into DV2Working Fixed conflicts in I2CtoFastLEDs and pjonToI2C code Adds CRGBArrayDebug / LCDExamples NanoWith1LedStripExample1 from kiki branch
Fix regString Needs trailing spaceregString should not need a trailing space, Possibly caused by setting to small an array in string.toCharArray() ArduinoStuff/2.aNCS_LED_DV2/DV2Working/pjonToI2C/pjonToI2C.ino Lines 18 to 23 in 2f9f995 This comment was generated by todo based on a
|
This was referenced Feb 15, 2019
Closed
|
Merged to master and DV2Working branch deleted. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging to master at current state as Pjon and everything else code wise is working as intended.
@kieran-boyle I would at this point see if its possible to back-merge Master into your branch and pull again
This merge should open me up a couple more small issues, More as a reminder to fix the little bugs than anything else.