Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords in UI and CLI displayed in plain text #5145

Closed
minsis opened this issue Feb 9, 2021 · 4 comments
Closed

Passwords in UI and CLI displayed in plain text #5145

minsis opened this issue Feb 9, 2021 · 4 comments
Labels

Comments

@minsis
Copy link
Contributor

minsis commented Feb 9, 2021

SUMMARY

UI and CLI clients both show clear text passwords when viewing the config

STACKSTORM VERSION

Paste the output of st2 --version:

st2 3.3.0, on Python 3.6.9

OS, environment, install method

Oracle 7 using st2-docker

Steps to reproduce the problem

Here I'm just using the core.remote action on an interval timer

Expected Results

Password shouldn't be displayed in clear text in the config. When going to edit or run the action the password is hidden.

Actual Results

What happened? What output did you get?

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
image

image

@blag
Copy link
Contributor

blag commented Feb 9, 2021

To be clear, the issue here is that, in the rule widget, action parameters and action runner parameters that are marked secret: true are not properly obfuscated by the server.

This probably also happens for the passphrase, private_key, and sudo_password parameters to the remote runner.

@stale
Copy link

stale bot commented Jun 2, 2021

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

@stale stale bot added the stale label Jun 2, 2021
@blag
Copy link
Contributor

blag commented Jun 2, 2021

A better place to report this might be https://github.com/StackStorm/st2web.

@minsis
Copy link
Contributor Author

minsis commented Jun 15, 2021

Moved to StackStorm/st2web#896

@minsis minsis closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants