Fix branch checkout logic #2601
Conversation
|
/cc @armab |
manasdk
force-pushed
the
v1.3.3_fix_checkout_logic
branch
from
9221287
to
faa8682
Compare
|
Yeah, if we want to go to a different branch in a shallow clone (--depth 1) we need to use the same "hack" as we use in st2contrib. |
| git checkout ${CIRCLE_BRANCH} || true | ||
| - .circle/buildenv.sh | ||
| - git clone -b ${CIRCLE_BRANCH} --single-branch --depth 1 ${ST2_PACKAGES_REPO} /home/ubuntu/st2/st2-packages | ||
| - /home/ubuntu/st2/st2-packages/.circle/buildenv.sh |
There was a problem hiding this comment.
- .circle/buildenv.sh
for consistency (see commands after this line).
Eg. this change is not needed, since it's current working dir.
There was a problem hiding this comment.
Are you sure? Without the cd the current working dir is not changed.
The entire CWD is non-obvious in cicle ci.
There was a problem hiding this comment.
Yes, sure.
The build dir is defined here:
...
general:
build_dir: st2-packagesThere was a problem hiding this comment.
Also FYI every command in Circle is run in separate subshell, so any vars or cd are not preserved across different commands, see: https://circleci.com/docs/configuration#phases
There was a problem hiding this comment.
That explains a bunch of behavior I am seeing.
There was a problem hiding this comment.
The entire CWD is non-obvious in cicle ci.
That's only start 😆
As said you before, it's not like Travis.
--depth 1means no branch info therefore the checkout will fail.