-
Notifications
You must be signed in to change notification settings - Fork 151
Conversation
… to acccept active as a mandatory argument
…into Aamir-raza-1-travisci
"preform_request". Also fix out of date descriptions.
…ady handles parsing off JSON), mark required argument as required in the metadata, return more information for each repo - just slug is not useful.
…impler and less error prone since user just needs to specified a token.
…fields), consistently use the underscore. Also fix more broken actions.
I fixed all the bugs and addressed all the issues. I will merge this into master, but we still need (better) documentation on how to obtain the access token. |
Let me see, the way of obtaining token, I'lll update today here |
@Aamir-raza-1 Alright, please open a new PR for those changes. |
@Kami We need to make changes to README. We first need to generate a Github token. Once that is generated we will send a |
@Aamir-raza-1 Yeah, in this case the user would only need to specify a Github token in the config file and we would dynamically retrieve Travis CI access token using it. One thing I'm not sure is (need to check the docs), if the /auth/github flow is possible without user-interaction (e.g. requiring user to open a browser, etc.). If it's not possible, then we can't do this automatically and we will need to write the instructions on how to do that and put it in the readme. If it's possible in this case, we can just go with that approach then - simply retrieve a new Travis CI access token on every action invocation - it's not ideally (ideally, we would re-use / cache the token), but it works fine for now. |
@Kami , Let me see, I guess the flow looks like this to me. |
Looks like Github auth token should work:
|
Hmm, Let me look what can we do with this. |
@Kami, How can I get the latest code that you have made changes to. When i clone it clones it from my fork and I have the same old code. I need the one that has been changed so that I can start making changes to. Thanks |
@Aamir-raza-1 Go to master, pull down the latest changes and include / make your changes in a new branch based of latest master: git checkout master
git pull origin master
git checkout -b my_new_branch_with_auth_changes
.... |
@Kami, Thats what I have already tried. Still the code changes that you have made are not visible and the actions travisci action also not cloned. |
@Aamir-raza-1 you are probably pulling from your fork repo and not upstream repo. Do: git remote add upstream https://github.com/StackStorm/st2contrib.git
git pull upstream master
... |
@Aamir-raza-1 Figured it out? |
Will work on it in sometime, I will sync my fork and add remote. Thanks |
I have synced my fork got the latest code, I am now going to write a function to retrieve travis API token, we need to have GIT api token in config file. |
@Aamir-raza-1 Yeah that's fine. Previously I removed it since it wasn't used in the code. |
@Kami, Hey sorry for the delay, I was off for EID holidays. I have created a PR. Please see #252 |
Fixes on top of #218