Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more youtube authors, and autocomplete for search off. #734

Merged
merged 1 commit into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/components/Chatbot/ChatEntry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,12 @@ const ReferenceSummary = ({
<div>
<div className={`black padding-bottom-8 ${titleClass}`}>{convertAscii(title)}</div>
<div className="small">
<Authors authors={authors} />
<span>{' · '}</span>
{source !== 'youtube' && (
<>
<Authors authors={authors} />
<span>{' · '}</span>
</>
)}
<Link className="source-link teal-500" to={url} target="_blank" rel="noopener noreferrer">
{referenceSources[source as keyof typeof referenceSources] || new URL(url).host}{' '}
<LinkIcon width="16" height="16" />
Expand Down
1 change: 1 addition & 0 deletions app/components/SearchInput/Input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const SearchInput = ({onChange, expandable, placeholderText}: SearchInput
<MagnifyingIcon className="iconsMagnifyingGlass" />
<input
name="searchbar"
autoComplete="off"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have explained. It stops this from happening.
image
I remembered Melissa saying she didn't like the autocomplete suggestions, because it covered up the search results. In hindsight though I don't actually think its that bad, because it does serve a purpose of remembering previous searches. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have just one or the other

placeholder={placeholderText ?? 'Search articles'}
className="search-input black"
onKeyDown={(e) => {
Expand Down
Loading