Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add onboarding_a column to onboarding table #1340

Merged
merged 3 commits into from
Oct 6, 2023
Merged

feat: add onboarding_a column to onboarding table #1340

merged 3 commits into from
Oct 6, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Oct 5, 2023 •
edited
Loading

@mamadoudicko mamadoudicko temporarily deployed to preview October 5, 2023 16:04 — with GitHub Actions Inactive
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Oct 5, 2023
@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:54am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:54am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:54am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023 •
edited
Loading

Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/databases/supabase/onboarding.py

The code is generally well-written and follows the SOLID principles. However, there is a potential issue with error handling. In the update_user_onboarding method, if the update operation fails, an HTTPException is raised with a 404 status code. This might be misleading as 404 is typically used for not found errors. Consider using a more appropriate status code, such as 500 for server errors. Also, it would be better to include more information in the error message, such as the user_id for which the update failed.

if not response:
    raise HTTPException(500, f\"User onboarding not updated for user_id: {user_id}\")

📝🚫🔍

Powered by Code Review GPT

@mamadoudicko mamadoudicko changed the title feat: add onboarding_a colummn to onboarding table feat: add onboarding_a column to onboarding table Oct 6, 2023
@mamadoudicko mamadoudicko temporarily deployed to preview October 6, 2023 07:49 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko merged commit 16cea2c into main Oct 6, 2023
10 of 11 checks passed
@StanGirard StanGirard mentioned this pull request Oct 6, 2023
Merged
masao-classcat pushed a commit to masao-classcat/quivr that referenced this pull request Oct 7, 2023
@classcat-air
Revert "feat: add onboarding_a column to onboarding table (QuivrHQ#1340…
bbd2c29 
…)"

This reverts commit 16cea2c.
gozineb pushed a commit that referenced this pull request Oct 9, 2023
@StanGirard
chore(main): release 0.0.89 (#1339)
bbf5e12 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in #1334
* feat: enhance user page UI by @nguernse in
#1319
* feat: update onboarding steps by @mamadoudicko in
#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
#1340
* fix(question): fixed with user_settings by @StanGirard in
#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
#1345
* test: add chat e2e tests by @mamadoudicko in
#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in #1364

## New Contributors
* @stanrb made their first contribution in
#1348

**Full Changelog**:
v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
@coolCatalyst
chore(main): release 0.0.89 (#1339)
7fd935d 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in QuivrHQ/quivr#1334
* feat: enhance user page UI by @nguernse in
QuivrHQ/quivr#1319
* feat: update onboarding steps by @mamadoudicko in
QuivrHQ/quivr#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
QuivrHQ/quivr#1340
* fix(question): fixed with user_settings by @StanGirard in
QuivrHQ/quivr#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
QuivrHQ/quivr#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
QuivrHQ/quivr#1345
* test: add chat e2e tests by @mamadoudicko in
QuivrHQ/quivr#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in QuivrHQ/quivr#1364

## New Contributors
* @stanrb made their first contribution in
QuivrHQ/quivr#1348

**Full Changelog**:
QuivrHQ/quivr@v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Dream528 added a commit to Dream528/quivr that referenced this pull request Jul 28, 2024
@Dream528
chore(main): release 0.0.89 (#1339)
795e71a 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in QuivrHQ/quivr#1334
* feat: enhance user page UI by @nguernse in
QuivrHQ/quivr#1319
* feat: update onboarding steps by @mamadoudicko in
QuivrHQ/quivr#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
QuivrHQ/quivr#1340
* fix(question): fixed with user_settings by @StanGirard in
QuivrHQ/quivr#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
QuivrHQ/quivr#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
QuivrHQ/quivr#1345
* test: add chat e2e tests by @mamadoudicko in
QuivrHQ/quivr#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in QuivrHQ/quivr#1364

## New Contributors
* @stanrb made their first contribution in
QuivrHQ/quivr#1348

**Full Changelog**:
QuivrHQ/quivr@v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gozineb gozineb gozineb approved these changes

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamadoudicko @gozineb