Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ⚙️🐞 configure debugger for the backend #1345

Merged
merged 3 commits into from
Oct 9, 2023
Merged

feat: ⚙️🐞 configure debugger for the backend #1345

merged 3 commits into from
Oct 9, 2023

Conversation

matthieujacq
Copy link
Contributor

No description provided.

@matthieujacq matthieujacq added the area: backend Related to backend functionality or under the /backend directory label Oct 6, 2023
@matthieujacq matthieujacq self-assigned this Oct 6, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 6, 2023 12:43 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 1:16pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 1:16pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 1:16pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Risk Level 2 - /home/runner/work/quivr/quivr/backend/main.py

The code changes are generally safe, but there are a few areas that could be improved for better code quality and maintainability.

  1. Environment Variables: It's good practice to handle the case where an environment variable is not set. In this case, if DEV_MODE or SENTRY_DSN is not set, the code should handle it gracefully. For example:
if os.getenv(\"DEV_MODE\") == \"true\":
    try:
        import debugpy
        logger.debug(\"👨‍💻 Running in dev mode\")
        debugpy.listen((\"0.0.0.0\", 5678))
    except ImportError:
        logger.error(\"debugpy module not found\")

  1. Error Handling: The handle_request_validation_error function could be improved by adding more specific error handling. Currently, it logs all validation errors with the same message, which might make it difficult to debug specific issues.

  2. Code Organization: The import statements are scattered throughout the file. It would be better to group all import statements at the top of the file for better readability and maintainability.

🔑🐛📚

Powered by Code Review GPT

@matthieujacq matthieujacq marked this pull request as ready for review October 9, 2023 12:32
gozineb
gozineb previously approved these changes Oct 9, 2023
View reviewed changes
@matthieujacq matthieujacq temporarily deployed to preview October 9, 2023 13:08 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 9, 2023 13:11 — with GitHub Actions Inactive
@matthieujacq matthieujacq merged commit fa92243 into main Oct 9, 2023
10 of 11 checks passed
@StanGirard StanGirard mentioned this pull request Oct 9, 2023
Merged
gozineb pushed a commit that referenced this pull request Oct 9, 2023
@StanGirard
chore(main): release 0.0.89 (#1339)
bbf5e12 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in #1334
* feat: enhance user page UI by @nguernse in
#1319
* feat: update onboarding steps by @mamadoudicko in
#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
#1340
* fix(question): fixed with user_settings by @StanGirard in
#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
#1345
* test: add chat e2e tests by @mamadoudicko in
#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in #1364

## New Contributors
* @stanrb made their first contribution in
#1348

**Full Changelog**:
v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
@coolCatalyst
chore(main): release 0.0.89 (#1339)
7fd935d 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in QuivrHQ/quivr#1334
* feat: enhance user page UI by @nguernse in
QuivrHQ/quivr#1319
* feat: update onboarding steps by @mamadoudicko in
QuivrHQ/quivr#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
QuivrHQ/quivr#1340
* fix(question): fixed with user_settings by @StanGirard in
QuivrHQ/quivr#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
QuivrHQ/quivr#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
QuivrHQ/quivr#1345
* test: add chat e2e tests by @mamadoudicko in
QuivrHQ/quivr#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in QuivrHQ/quivr#1364

## New Contributors
* @stanrb made their first contribution in
QuivrHQ/quivr#1348

**Full Changelog**:
QuivrHQ/quivr@v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Dream528 added a commit to Dream528/quivr that referenced this pull request Jul 28, 2024
@Dream528
chore(main): release 0.0.89 (#1339)
795e71a 
🤖 I have created a release *beep* *boop*
---


## 0.0.89 (2023-10-09)

## What's Changed
* feat: enable CSP in all environments (local/preview/prod) by
@matthieujacq in QuivrHQ/quivr#1334
* feat: enhance user page UI by @nguernse in
QuivrHQ/quivr#1319
* feat: update onboarding steps by @mamadoudicko in
QuivrHQ/quivr#1337
* feat: add onboarding_a column to onboarding table by @mamadoudicko in
QuivrHQ/quivr#1340
* fix(question): fixed with user_settings by @StanGirard in
QuivrHQ/quivr#1349
* FIX tables.sql - missing ; breaks SQL queries. by @stanrb in
QuivrHQ/quivr#1348
* feat: ⚙️🐞 configure debugger for the backend by @matthieujacq in
QuivrHQ/quivr#1345
* test: add chat e2e tests by @mamadoudicko in
QuivrHQ/quivr#1344
* feat: configure CSP for self-hosting and multiple ports in dev mode by
@matthieujacq in QuivrHQ/quivr#1364

## New Contributors
* @stanrb made their first contribution in
QuivrHQ/quivr#1348

**Full Changelog**:
QuivrHQ/quivr@v0.0.88...v0.0.89

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamadoudicko mamadoudicko mamadoudicko approved these changes

@gozineb gozineb gozineb left review comments

Assignees

@matthieujacq matthieujacq

Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieujacq @mamadoudicko @gozineb