Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize bitshuffle and crc for ARM (backport #44607) #44827

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 26, 2024

Why I'm doing:

Optimize performance on the ARM platform.

What I'm doing:

  1. Bitshuffle
    Thanks for [arm64] use a better translation for move_mask kiyo-masui/bitshuffle#140. Apply this patch to optimize bishuffle.

  2. CRC
    Use NEON __crc32cw intrinsic to optimize crc32c::Extend.

  3. Use __ARM_NEON instead of __ARM_NEON__
    __ARM_NEON__ is a legacy, and isn't defined in ARM v8. ARM v8 only defines __ARM_NEON. Since we have already compiled with -march=armv8-a+crc, it is safe to replace __ARM_NEON__ with __ARM_NEON.
    See ARM C Language Extensions, GCC, and Stack Overflow for detail.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #44607 done by [Mergify](https://mergify.com). ## Why I'm doing:

Optimize performance on the ARM platform.

What I'm doing:

  1. Bitshuffle
    Thanks for [arm64] use a better translation for move_mask kiyo-masui/bitshuffle#140. Apply this patch to optimize bishuffle.

  2. CRC
    Use NEON __crc32cw intrinsic to optimize crc32c::Extend.

  3. Use __ARM_NEON instead of __ARM_NEON__
    __ARM_NEON__ is a legacy, and isn't defined in ARM v8. ARM v8 only defines __ARM_NEON. Since we have already compiled with -march=armv8-a+crc, it is safe to replace __ARM_NEON__ with __ARM_NEON.
    See ARM C Language Extensions, GCC, and Stack Overflow for detail.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: zihe.liu <ziheliu1024@gmail.com>
(cherry picked from commit 92e6bf6)
@mergify mergify bot requested a review from a team as a code owner April 26, 2024 08:56
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 26, 2024 08:57
@wanpengfei-git wanpengfei-git merged commit 094c31f into branch-3.2 Apr 28, 2024
33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-44607 branch April 28, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants