Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incompatible with Immersive Vehicles #77

Closed
nrllewellyn opened this issue Oct 13, 2019 · 8 comments
Closed

[Bug] Incompatible with Immersive Vehicles #77

nrllewellyn opened this issue Oct 13, 2019 · 8 comments

Comments

@nrllewellyn
Copy link

nrllewellyn commented Oct 13, 2019

Describe the bug
Installing OCGlasses prevents Immersive Vehicles' controls screen form displaying.

In which environment did the Bug appear?
Single Player and Dedicated Server

To Reproduce
Steps to reproduce the behavior:

  1. Install OCGlasses and Immersive Vehicles
  2. Try to open the Open Vehicles controls screen

Expected behavior
Controls screen should open

Screenshots / Code Snippet
N/A

Minecraft:

  • OpenGlasses-MC1.12.2-2.2-36
  • OpenComputers-MC1.12.2-1.7.4.153
  • Immersive+Vehicles-1.12.2-15.3.0
  • Minecraft 1.12
  • Forge 14.23.5.2847

Additional context
Bug will be cross-posted to Immersive Vehicle's Github, and I will post a link shortly.

@nrllewellyn
Copy link
Author

Issue in Immersive Vehicle's Github: DonBruce64/MinecraftTransportSimulator#199

@nrllewellyn
Copy link
Author

Note: This appears to be an issue with the way one of the mods does keybindings, as with both mods installed the keybinding for Immersive Vehicles controls is labeled as "Glasses Config" in the controls menu.

@nrllewellyn
Copy link
Author

nrllewellyn commented Oct 13, 2019

With OCGlasses installed:
2019-10-13_02 43 27

@nrllewellyn
Copy link
Author

Without OCGlasses installed:
2019-10-13_02 45 08

@ben-mkiv
Copy link
Collaborator

both mods, screwed up their translation keys.

@DonBruce64
Copy link

Yup, that's a bad on my end. I have the lang file set to "key.config", so that explains why it would conflict with your mod. I swore I got everything converted to use my modID as a prefix in the lang file after I had conflicts with block names, but I guess I missed the controls. Still shouldn't keep the user from opening the config, though, as the binding has a separate category. He should see two "Config Glasses" sections, one under MTS and one under OCG. Unless Forge's keybindings don't care about category and only care about the binding name....

Currently in the process of re-writing my mod for less pain to update to 1.14.4, so I won't be able to get to this for a while. Will let you know when I do.

@ben-mkiv
Copy link
Collaborator

I've uploaded a fixed version of OpenGlasses (2.2-38) to Curse/Twitch

@DonBruce64
Copy link

Should close the loop and say V15.4.0 of my mod has corrected this on my end as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants