Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector3::IsNormalized #90

Open
eljeffeg opened this issue Dec 29, 2018 · 0 comments
Open

Vector3::IsNormalized #90

eljeffeg opened this issue Dec 29, 2018 · 0 comments
Assignees

Comments

@eljeffeg
Copy link
Member

We're getting this error on some models. In particular, I noticed it on the two Human Titans. Not sure if it's something that we need to fix, but I thought I would document it for review in case the fix was easy.

Assert @ C:\Projects\P4\SinsDiplomacy\Release\CodeSource\GS/Galaxy/GalaxyOrientation.cpp(23)
Vector3::IsNormalized(m_orientation.GetCross())

Explosions on a bad model.

The error is caused by lines in the model that were not polys, the explosion attaches to one of the lines it spits the error. And when a lot of models have it, trying to run test games is a real nightmare.

badmodel

Have to raycast select all the polys and hide them, get a section done like above and delete the lines, unhide and weld everything where the lines were to get proper tangent lighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants