New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate shadow stack #74

Open

playXE opened this issue Jul 6, 2021 · 1 comment

Labels

good first issue help wanted

Collaborator

playXE commented Jul 6, 2021

Since GC now can find pointers to the heap on the stack shadow stack is almost useless now.

Depends on #73 so we can find JS values on the stack.

Collaborator Author

playXE commented Jul 10, 2021

We should slowly start remove uses of letroot!. Rules for removing it are simple:

if letroot is used to root JsValue then remove its usage
if letroot is used to root GcPointer or WeakRef or any struct that is allocated on stack and contains GC pointer remove its usage
if letroot is used to root Vec,Box or other non GC allocated type that might point to GC objects do not remove letroot

playXE added good first issue help wanted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment