Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: directories with sticky bit cannot be backed up to some filesystems (exfat) using rsync #2564

Closed
1 task done
gStart9 opened this issue Feb 26, 2024 · 1 comment
Closed
1 task done
Assignees
Labels
Bug Something isn't working Needs Triage Needs to be assigned a priority
Milestone

Comments

@gStart9
Copy link
Member

gStart9 commented Feb 26, 2024

Prerequisites

Server Hardware

All

StartOS Version

0351

Client OS

Linux

Client OS Version

All

Browser

Firefox

Browser Version

122

Current Behavior

image

root@upright-plunder:/embassy-data/package-data/volumes/lightning-terminal/data/main# ls -al
total 0
drwxr-xr-x 1 root root 28 Feb 26 18:56 .
drwxr-xr-x 1 root root 26 Feb 26 18:56 ..
drwxr-xr-x 1 root root 16 Feb 26 18:56 .lit
drwxr-xr-t 1 root root 0 Feb 26 18:56 .lnd
drwxr-xr-x 1 root root 22 Feb 26 18:56 start9

^this .lnd directory has a sticky bit set because it's mounted inside Lit container from the LND container

Sticky bit. It was used to trigger process to "stick" in memory after it is finished, now this usage is obsolete. Currently its use is system dependent and it is mostly used to suppress deletion of the files that belong to other users in the folder where you have "write" access to.
http://www.zzee.com/solutions/linux-permissions.shtml#setuid

Technically this may be a StartOS bug, but I believe the preferred solution will be to exclude the .lnd directory from the LiT backup -- Lit should not backup externally mounted .lnd directory -- LND should. (This indeed fixed lit)

An alternative could be to mount the .lnd directory with different permissions initially, or instruct rsync to discard the sticky bit permissions on copy.

Expected Behavior

Backup should not fail

Steps to Reproduce

  1. Insert a physical disk formatted exfat
  2. Attempt to perform a backup with where Lit is involved
  3. See failure in the details of the backup report

Anything else?

No response

@gStart9 gStart9 added Bug Something isn't working Needs Triage Needs to be assigned a priority labels Feb 26, 2024
@gStart9 gStart9 changed the title [bug]: directories with sticky bit cannot be backed up to some filesystems (exfat) [bug]: directories with sticky bit cannot be backed up to some filesystems (exfat) using rsync Feb 26, 2024
@MattDHill
Copy link
Member

solved by start-fs fuse module

@MattDHill MattDHill added this to the 0.3.6 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Triage Needs to be assigned a priority
Projects
None yet
Development

No branches or pull requests

2 participants