Build failure with 0.1.8 on NetBSD

[brson]

I don't actually use NetBSD but this happened recently with rustup:

+ cargo build --release --target x86_64-unknown-netbsd

    Updating registry `https://github.com/rust-lang/crates.io-index`

    Updating git repository `https://github.com/ctz/rustls.git`

    Updating git repository `https://github.com/sfackler/rust-native-tls.git`

    Updating git repository `https://github.com/Diggsey/markdown.rs.git`

    Updating git repository `https://github.com/ctz/ring`

    Updating git repository `https://github.com/ctz/webpki`

    Updating git repository `https://github.com/sfackler/schannel-rs`

 Downloading term v0.4.4

 Downloading clap v2.10.2

 Downloading tempfile v2.1.4

 Downloading error-chain v0.4.2

 Downloading sha2 v0.1.2

 Downloading rand v0.3.14

 Downloading regex v0.1.73

 Downloading rustc-serialize v0.3.19

 Downloading scopeguard v0.1.2

 Downloading tempdir v0.3.4

 Downloading toml v0.1.30

 Downloading time v0.1.35

 Downloading itertools v0.4.18

 Downloading url v1.1.1

 Downloading libc v0.2.14

 Downloading winapi v0.2.8

 Downloading kernel32-sys v0.2.2

 Downloading winapi-build v0.1.1

 Downloading unicode-width v0.1.3

 Downloading ansi_term v0.8.0

 Downloading bitflags v0.7.0

 Downloading vec_map v0.6.0

 Downloading term_size v0.1.0

 Downloading strsim v0.4.1

 Downloading rustc_version v0.1.7

 Downloading semver v0.1.20

 Downloading backtrace v0.2.3

 Downloading dbghelp-sys v0.2.0

 Downloading rustc-demangle v0.1.1

 Downloading backtrace-sys v0.1.4

 Downloading cfg-if v0.1.0

 Downloading gcc v0.3.32

 Downloading curl v0.3.0

 Downloading env_proxy v0.1.1

 Downloading hyper v0.9.10

 Downloading curl-sys v0.2.0

 Downloading libz-sys v1.0.4

 Downloading pkg-config v0.3.8

 Downloading idna v0.1.0

 Downloading matches v0.1.2

 Downloading unicode-bidi v0.2.3

 Downloading unicode-normalization v0.1.2

 Downloading httparse v1.1.2

 Downloading log v0.3.6

 Downloading cookie v0.2.5

 Downloading typeable v0.1.2

 Downloading traitobject v0.0.1

 Downloading num_cpus v0.2.13

 Downloading solicit v0.4.4

 Downloading language-tags v0.2.2

 Downloading mime v0.2.1

 Downloading unicase v1.4.0

 Downloading hpack v0.2.0

 Downloading utf8-ranges v0.1.3

 Downloading memchr v0.1.11

 Downloading regex-syntax v0.3.4

 Downloading aho-corasick v0.5.2

 Downloading thread_local v0.2.6

 Downloading thread-id v2.0.0

 Downloading tar v0.4.8

 Downloading walkdir v0.1.5

 Downloading ole32-sys v0.2.0

 Downloading flate2 v0.2.14

 Downloading filetime v0.1.10

 Downloading lazy_static v0.1.16

 Downloading wait-timeout v0.1.3

 Downloading miniz-sys v0.1.7

 Downloading pipeline v0.5.0

 Downloading openssl-sys v0.7.14

 Downloading openssl v0.7.14

 Downloading openssl-verify v0.1.0

 Downloading lazy_static v0.2.1

 Downloading openssl-sys-extras v0.7.14

 Downloading xattr v0.1.8

   Compiling itertools v0.4.18

   Compiling backtrace v0.2.3

   Compiling typeable v0.1.2

   Compiling utf8-ranges v0.1.3

   Compiling libc v0.2.14

   Compiling xattr v0.1.8

error[E0432]: unresolved import `sys::XAttrs`. There is no `XAttrs` in `sys`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:15:9

   |

15 | pub use sys::XAttrs;

   |         ^^^^^^^^^^^

error[E0425]: unresolved name `sys::get_path`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:22:5

   |

22 |     sys::get_path(path.as_ref(), name.as_ref())

   |     ^^^^^^^^^^^^^

error[E0425]: unresolved name `sys::set_path`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:30:5

   |

30 |     sys::set_path(path.as_ref(), name.as_ref(), value)

   |     ^^^^^^^^^^^^^

error[E0425]: unresolved name `sys::remove_path`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:38:5

   |

38 |     sys::remove_path(path.as_ref(), name.as_ref())

   |     ^^^^^^^^^^^^^^^^

error[E0425]: unresolved name `sys::list_path`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:48:5

   |

48 |     sys::list_path(path.as_ref())

   |     ^^^^^^^^^^^^^^

error[E0425]: unresolved name `sys::get_fd`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:56:9

   |

56 |         sys::get_fd(self.as_raw_fd(), name.as_ref())

   |         ^^^^^^^^^^^

error[E0425]: unresolved name `sys::set_fd`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:63:9

   |

63 |         sys::set_fd(self.as_raw_fd(), name.as_ref(), value)

   |         ^^^^^^^^^^^

error[E0425]: unresolved name `sys::remove_fd`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:70:9

   |

70 |         sys::remove_fd(self.as_raw_fd(), name.as_ref())

   |         ^^^^^^^^^^^^^^

error[E0425]: unresolved name `sys::list_fd`

  --> target/cargo-home/registry/src/github.com-1ecc6299db9ec823/xattr-0.1.8/src/lib.rs:78:9

   |

78 |         sys::list_fd(self.as_raw_fd())

   |         ^^^^^^^^^^^^

error: aborting due to 9 previous errors

Build failed, waiting for other jobs to finish...

error: Could not compile `xattr`.

[Stebalien]

We didn't have NetBSD support but I've added it (untested...). As far as I can tell, the NetBSD xattrs API is the same as FreeBSD's. Unfortunately, I don't use any *BSD so I have no way of testing this (and no way to know if it even compiles on those platforms).

Do you think it would be a good idea to add mock support for unsupported platforms (i.e., always return an io::Error)?

[Stebalien]

See #8.

[alexcrichton]

Adding support like this seems reasonable to me!

[Stebalien]

@alexcrichton the latest version, 0.1.10, includes (untested) support for NetBSD (same as FreeBSD) and no-op support for unsupported platforms (so this library should always build).

[alexcrichton]

Thanks @Stebalien!

[Stebalien]

Unless I'm informed otherwise, I'm going to assume the fix works.